Merge pull request 'Improve error handling in feedback retrieval by returning a specific error when feedback is not found for a given tender ID and customer ID.' (#32) from TM-571 into develop
Reviewed-on: https://repo.ravanertebat.com/TM/tm_back/pulls/32 Reviewed-by: Hadi Barzegar <barzagarhadi@gmail.com>
This commit is contained in:
@@ -198,6 +198,9 @@ func (r *feedbackRepository) GetByTenderIDForCustomer(ctx context.Context, tende
|
||||
|
||||
result, err := r.repo.FindOne(ctx, filter)
|
||||
if err != nil {
|
||||
if errors.Is(err, orm.ErrDocumentNotFound) {
|
||||
return nil, ErrFeedbackNotFound
|
||||
}
|
||||
r.logger.Error("Failed to get feedback by tender ID and customer ID", map[string]interface{}{
|
||||
"tender_id": tenderID,
|
||||
"customer_id": customerID,
|
||||
|
||||
@@ -187,11 +187,13 @@ func (s *feedbackService) GetByTenderID(ctx context.Context, tenderID, companyID
|
||||
func (s *feedbackService) GetByTenderIDForCustomer(ctx context.Context, tenderID, customerID string) (*FeedbackResponse, error) {
|
||||
feedback, err := s.feedbackRepo.GetByTenderIDForCustomer(ctx, tenderID, customerID)
|
||||
if err != nil {
|
||||
s.logger.Error("Failed to get feedback by tender ID for customer", map[string]interface{}{
|
||||
"tender_id": tenderID,
|
||||
"customer_id": customerID,
|
||||
"error": err.Error(),
|
||||
})
|
||||
if !errors.Is(err, ErrFeedbackNotFound) {
|
||||
s.logger.Error("Failed to get feedback by tender ID for customer", map[string]interface{}{
|
||||
"tender_id": tenderID,
|
||||
"customer_id": customerID,
|
||||
"error": err.Error(),
|
||||
})
|
||||
}
|
||||
return nil, err
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user