mazyar/tm_back
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update tender approval handler documentation and default status logic
continuous-integration/drone/push Build is passing
Details

Browse Source 
- Enhanced API documentation for `GetTenderApprovalByTenderAndCompany` to clarify the default behavior of the status filter, indicating it defaults to 'submitted' when omitted.
- Updated the `PublicGetTenderApprovals` method to set the default status to 'submitted' if no status is provided, ensuring consistent behavior in approval retrieval.

This update improves the clarity of the API documentation and enhances the functionality of the tender approval retrieval process by establishing a default status, thereby improving user experience.
This commit is contained in:
Mazyar
2026-07-03 16:23:42 +03:30
parent 541d08a014
commit ec7db8b9f0
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/tender_approval/handler.go
+5 -2
View File
@@ -132,7 +132,7 @@ func (h *Handler) GetTenderApprovalByTenderAndCompany(c echo.Context) error {
// @Param limit query integer false "Number of approvals per page (1-100)" minimum(1) maximum(100) default(20) // @Param limit query integer false "Number of approvals per page (1-100)" minimum(1) maximum(100) default(20)
// @Param offset query integer false "Number of approvals to skip for pagination" minimum(0) default(0) // @Param offset query integer false "Number of approvals to skip for pagination" minimum(0) default(0)
// @Param submission_mode query string false "Filter by submission mode Enums(self-apply, partnership)" // @Param submission_mode query string false "Filter by submission mode Enums(self-apply, partnership)"
// @Param status query string false "Filter by status Enums(submitted, rejected)" // @Param status query string false "Filter by status Enums(submitted, rejected). Defaults to submitted when omitted."
// @Param created_from query integer false "Filter by created date from (Unix timestamp)" // @Param created_from query integer false "Filter by created date from (Unix timestamp)"
// @Param created_to query integer false "Filter by created date to (Unix timestamp)" // @Param created_to query integer false "Filter by created date to (Unix timestamp)"
// @Success 200 {object} response.APIResponse{data=TenderApprovalWithTenderListResponse} "Tender approvals retrieved successfully" // @Success 200 {object} response.APIResponse{data=TenderApprovalWithTenderListResponse} "Tender approvals retrieved successfully"
@@ -176,7 +176,7 @@ func (h *Handler) PublicGetTenderApprovals(c echo.Context) error {
submissionMode = &mode submissionMode = &mode
} }
// Parse status filter // Parse status filter; default to submitted so "Your Tenders" excludes rejected approvals
var status *ApprovalStatus var status *ApprovalStatus
if statusStr != "" { if statusStr != "" {
statusVal := ApprovalStatus(statusStr) statusVal := ApprovalStatus(statusStr)
@@ -184,6 +184,9 @@ func (h *Handler) PublicGetTenderApprovals(c echo.Context) error {
return response.BadRequest(c, "Invalid status value", "Must be 'submitted' or 'rejected'") return response.BadRequest(c, "Invalid status value", "Must be 'submitted' or 'rejected'")
} }
status = &statusVal status = &statusVal
} else {
defaultStatus := ApprovalStatusSubmitted
status = &defaultStatus
} }
var from *int64 var from *int64