From 4051cb156cea0d393ff35bbaf3270c091a782f84 Mon Sep 17 00:00:00 2001
From: AmirReza Jamali <amir7jamali.ar@yahoo.com>
Date: Tue, 7 Jul 2026 16:09:50 +0330
Subject: [PATCH] fix: improve inquiry status change and notification refresh

Block no-op inquiry status updates, refetch active my-notifications after create, and use the shared error text token on Select validation messages.

Co-authored-by: Cursor <cursoragent@cursor.com>
---
 src/components/FormElements/select.tsx            |  2 +-
 .../Tables/inquiries/ChangeStatusForm.tsx         | 15 +++++++++++----
 src/hooks/queries/useNotificationQueries.ts       |  4 ++++
 3 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/src/components/FormElements/select.tsx b/src/components/FormElements/select.tsx
index 1ea6ce2..f60ed0b 100644
--- a/src/components/FormElements/select.tsx
+++ b/src/components/FormElements/select.tsx
@@ -618,7 +618,7 @@ export function Select<T extends FieldValues>(selectProps: PropsType<T>) {
         {dropdown}
 
       {error && (
-        <p className="text-red mt-1.5 text-sm font-medium">
+        <p className="mt-1.5 text-sm font-medium text-error">
           {error.message as string}
         </p>
       )}
diff --git a/src/components/Tables/inquiries/ChangeStatusForm.tsx b/src/components/Tables/inquiries/ChangeStatusForm.tsx
index ca01634..82fd8a8 100644
--- a/src/components/Tables/inquiries/ChangeStatusForm.tsx
+++ b/src/components/Tables/inquiries/ChangeStatusForm.tsx
@@ -11,14 +11,12 @@ interface ChangeStatusFormProps {
   onSubmit: (data: TChangeInquiryStatusCredentials) => void;
   onCancel: () => void;
   currentStatus: string;
-
 }
 
 const ChangeStatusForm = ({
   onSubmit,
   onCancel,
   currentStatus,
-
 }: ChangeStatusFormProps) => {
   const {
     register,
@@ -37,10 +35,19 @@ const ChangeStatusForm = ({
     value: status,
   }));
 
+  const handleStatusSubmit = (data: TChangeInquiryStatusCredentials) => {
+    if (data.status === currentStatus) return;
+    onSubmit(data);
+  };
+
   return (
-    <form onSubmit={handleSubmit(onSubmit)} className="space-y-4">
+    <form onSubmit={handleSubmit(handleStatusSubmit)} className="space-y-4">
       <Select
-        {...register("status", { required: "Status is required" })}
+        {...register("status", {
+          required: "Status is required",
+          validate: (value) =>
+            value !== currentStatus || "Select a different status",
+        })}
         name="status"
         label="Status"
         items={statusOptions}
diff --git a/src/hooks/queries/useNotificationQueries.ts b/src/hooks/queries/useNotificationQueries.ts
index d3175fa..6d1ce0f 100644
--- a/src/hooks/queries/useNotificationQueries.ts
+++ b/src/hooks/queries/useNotificationQueries.ts
@@ -70,6 +70,10 @@ export const useCreateNotificationQuery = (successCallback?: () => void) => {
       queryClient.invalidateQueries({
         queryKey: [API_ENDPOINTS.NOTIFICATIONS.MY_NOTIFICATIONS],
       });
+      queryClient.refetchQueries({
+        queryKey: [API_ENDPOINTS.NOTIFICATIONS.MY_NOTIFICATIONS],
+        type: "active",
+      });
       if (successCallback) {
         successCallback();
       }